Conversation
|
There was a problem hiding this comment.
Pull request overview
This PR cleans up CI and package configuration by standardizing dependency installation, removing unused commands, and improving the release workflow.
Changes:
- Standardized all
npm icommands tonpm ciin CI workflows for more reliable builds - Added
--if-presentflags to version and release commands to prevent failures when scripts don't exist - Consolidated Storybook setup by moving asset copying into snapshot commands
Reviewed changes
Copilot reviewed 9 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/skin/package.json | Removed unused release and version scripts, added Storybook setup to snapshot commands |
| packages/evo-react/package.json | Changed test command from watch mode to run mode |
| packages/evo-marko/package.json | Simplified release script and removed unused version script |
| packages/ebayui-core/package.json | Added mtc to prepublishOnly script |
| packages/ebayui-core-react/vite.config.mjs | Added global window definition to fix test issues |
| packages/ebayui-core-react/package.json | Updated test and release scripts for consistency |
| package.json | Added --if-present flags to version/release scripts, consolidated build workspace flags |
| .github/workflows/percy.yml | Changed to npm ci and removed redundant asset copy step |
| .github/workflows/ci.yml | Changed to npm ci and removed unused npm update step |
Files not reviewed (3)
- packages/ebayui-core-react/smoke-tests/react-16/package-lock.json: Language not supported
- packages/ebayui-core-react/smoke-tests/react-18/package-lock.json: Language not supported
- packages/ebayui-core-react/smoke-tests/react-19/package-lock.json: Language not supported
| "start": "NODE_OPTIONS=--openssl-legacy-provider storybook dev -p 9001 -c .storybook --no-open", | ||
| "storybook": "NODE_OPTIONS=--openssl-legacy-provider storybook dev -p 9001 -c .storybook --no-open", | ||
| "test": "vitest", | ||
| "test": "vitest run", |
There was a problem hiding this comment.
Noooo 😢 ! This is because CI=false in local development. It is so cool to have npm test having watch by default
There was a problem hiding this comment.
That's fine but we should do vitest run for build. It hangs in build because of that
Or change the build to do ci=true?
| "release": "npm run build", | ||
| "start": "storybook dev -p 9001", | ||
| "test": "vitest --browser.headless --passWithNoTests", | ||
| "test": "vitest run --browser.headless --passWithNoTests", |
Several CI/package changes
--if-presentto version and release commandsdefineto vitest for react (to hopefully fix an issue with pagination failing randomly)